public-collect/books-futures-explained
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
217 Commits 4 Branches 1 Tag
760fd57be398192ca797cee8ff74c8b217d0dbab
Commit Graph

217 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Carl Fredrik Samson
760fd57be3 Fixed naked function with arguments in green threads example. See https://github.com/cfsamson/example-greenthreads/issues/20 for more information. 2020-12-06 00:44:31 +01:00
Carl Fredrik Samson
3ba348601a prevent wake_by_ref from decreasing refcount. Fixes #22 2020-12-05 23:01:35 +01:00
Carl Fredrik Samson
8dfd7f445c updated links to fix #21 2020-12-05 22:11:41 +01:00
Carl Fredrik Samson
2128fc83d6 updated code comments re #20 2020-08-23 23:22:06 +02:00
Carl Fredrik Samson
734763b969 Merge pull request #20 from oblique/master 
Fix `size` and `align` of raw vtable
 2020-08-23 23:10:28 +02:00
oblique
527ec3835c waker context: Print size of Box<Box<SomeTrait>> 2020-08-09 22:10:13 +03:00
oblique
b0ca76b3d5 waker context: Fix size and align of raw vtable 2020-08-09 22:00:30 +03:00
Carl Fredrik Samson
4f275f1339 Merge pull request #18 from Yoric/patch-1 
Typo fix
 2020-05-31 11:02:22 +02:00
David Teller
3ce63ffd13 Typo fix 2020-05-31 10:51:18 +02:00
Carl Fredrik Samson
467578773f changed the green threads example to use llvm_asm due to https://github.com/rust-lang/rust/pull/69171 2020-05-20 23:09:11 +02:00
Carl Fredrik Samson
90f16be8e4 Merge pull request #17 from jamesrobb/jr_spelling_grammar 
Small corrections to spelling, grammar, and a few phrases.
 2020-05-19 14:44:57 +02:00
James Robb
6e75083b0e Phrase correction. The phrase sounded strange, so I took a stab at what I think the author meant. 2020-05-19 11:38:53 +00:00
James Robb
39169b737f Small conjugation correction. 2020-05-19 11:38:12 +00:00
James Robb
65401cbaf3 Small spelling and conjugation corrections. 2020-05-19 11:09:13 +00:00
James Robb
c7bb485b8a Small spelling and conjugation corrections. 2020-05-19 10:53:20 +00:00
James Robb
30b6e394c6 Small spelling corrections. 2020-05-19 10:37:38 +00:00
James Robb
6b41d2ff6d Mostly corrections to conjugation. 2020-05-19 10:28:27 +00:00
James Robb
ac5d80aa64 Oxford comma. 2020-05-19 10:11:53 +00:00
James Robb
18584400c7 Slightly awkward wording. 2020-05-19 10:08:21 +00:00
James Robb
92de09e917 Slightly awkward wording. 2020-05-19 10:06:23 +00:00
James Robb
aeb1c93449 Hyphen does not remove any ambiguity. 2020-05-19 10:03:47 +00:00
Carl Fredrik Samson
5fc2932899 Merge pull request #16 from WindSoilder/master 
fix typo
 2020-05-07 09:15:18 +02:00
WindSoilder
2d7d9f4680 fix typo 2020-05-07 09:04:16 +08:00
Carl Fredrik Samson
07aab4e76b Merge pull request #15 from WindSoilder/master 
remove useless comment
 2020-05-06 20:43:20 +02:00
WindSoilder
5da61651ba remove useless comment 2020-05-06 17:23:17 +08:00
Carl Fredrik Samson
0d669a8034 Merge pull request #14 from WindSoilder/master 
make code compile, and fix typo
 2020-05-06 08:58:14 +02:00
WindSoilder
41b28f466f make code compile, and fix typo 2020-05-06 09:11:03 +08:00
Carl Fredrik Samson
786faf4fd9 Removed the explicit call to close and mentioned a bug that can occur 
when two tasks is given the same id.

The explicit close call is not needed. We can do that in the `Drop`
implementation instead. It's better to have accounting tasks like this
only one place and it didn't add anything to the example.

There is a subtle bug which occurs if two tasks are given the same Id.
I mentioned this explicitly since it's such an easy thing to do. I
added the fix as a reader excercise since for the examples sake I think
it's better to pass them in explicitly so that we don't "pollute" the
example with more code than strictly needed to get an understanding of
futures.
 2020-04-27 00:02:41 +02:00
Carl Fredrik Samson
7db0aaa991 cleaned up and removed book directory for cleaner diffs 2020-04-18 02:31:57 +02:00
Carl Fredrik Samson
f4deaaf87b fix outdated links re: #13 2020-04-18 02:28:53 +02:00
Carl Fredrik Samson
a4c161c060 Merge pull request #12 from DarkEld3r/patch-1 
Fix minor typo (som -> some)
 2020-04-17 22:12:57 +02:00
Stanislav Tkach
66d706b9e5 Fix minor typo (som -> some) 2020-04-17 17:44:07 +03:00
Carl Fredrik Samson
8689ac98cc Merge pull request #11 from chengcyber/master 
💄 panic button in mobile
 2020-04-16 11:24:19 +02:00
Cheng
ad5bc20676 💄 panic button in mobile 2020-04-16 10:41:38 +08:00
Carl Fredrik Samson
a2f9535f3e fist sentence might be confusing, so I changed it 2020-04-14 23:56:59 +02:00
Carl Fredrik Samson
fbef19b079 more precise wording and fixed heap-pinning example which didn't work as expected 2020-04-14 23:51:54 +02:00
Carl Fredrik Samson
bd7e3c5572 added link to Chinese translation rec#issuecomment-613319223 + minor cleanup of code in Pin chapter 2020-04-14 23:05:54 +02:00
Carl Fredrik Samson
2fc79a9e03 added playground links to show problem using thread park/unpark 2020-04-14 00:37:03 +02:00
Carl Fredrik Samson
08b155698c Merge branch 'master' of https://github.com/cfsamson/books-futures-explained 2020-04-13 14:21:00 +02:00
Carl Fredrik Samson
d9eb756ef7 Added Bonus Section implementing a proper Parker 
The problems addressed in the earlier version led to an "incorrect"
example which is bad to pass along after reading a whole book. after
getting some feedback in #2 i decided to show how we can create a
proper `Parker`.

The main example (which I assume most interested readers will copy) now
uses a proper parking thechnique so there should be no more dataraces
left.

I also removed the "Reader Excercise" paragraph suggesting that they
explore a way to implement proper parking since we now show that in
our main example.
 2020-04-13 14:16:32 +02:00
Carl Fredrik Samson
d2bcca7aa6 Merge pull request #10 from ianthetechie/master 
Fix minor typo
 2020-04-12 10:14:40 +02:00
Ian Wagner
1520be032c Fix minor typo 2020-04-12 16:59:56 +09:00
Carl Fredrik Samson
6c38c20d16 Merge pull request #9 from eupn/patch-2 
6_future_example.md: fix typo
 2020-04-12 01:02:27 +02:00
Carl Fredrik Samson
3a31d08a9c Merge pull request #8 from eupn/patch-1 
4_pin.md: fix typo
 2020-04-12 01:01:50 +02:00
eupn
3757194684 6_future_example.md: fix typo 2020-04-12 01:52:17 +08:00
eupn
79a04ce025 4_pin.md: fix typo 2020-04-12 01:35:18 +08:00
Carl Fredrik Samson
f4b2029788 Merge pull request #7 from MarinPostma/typo-future 
fix typo in code example
 2020-04-11 00:28:49 +02:00
Carl Fredrik Samson
73363e0583 Merge branch 'master' into typo-future 2020-04-11 00:27:21 +02:00
Carl Fredrik Samson
02bb33c6b6 minor fixes to the debug printout of the main example 2020-04-11 00:23:39 +02:00
marin
9744403a6b fix typo in code example 2020-04-10 23:46:59 +02:00