Commit Graph

228 Commits

Author SHA1 Message Date
Carl Fredrik Samson
3a2d252468 fixed spelling mistake in slide 0 2020-12-22 14:31:36 +01:00
Carl Fredrik Samson
ef4be98f4f Merge branch 'master' of https://github.com/cfsamson/books-futures-explained into master 2020-12-22 14:25:31 +01:00
Carl Fredrik Samson
05437bc6b5 added new slides re #25 2020-12-22 14:21:41 +01:00
Carl Fredrik Samson
7dc65df0f4 Merge pull request #27 from RicoGit/patch-1
Update 1_futures_in_rust.md
2020-12-21 19:37:57 +01:00
Constantine Solovev
f38bc31bd3 Update 1_futures_in_rust.md 2020-12-21 21:00:52 +04:00
Carl Fredrik Samson
4f4e6be15a updated changelog ref #25 2020-12-21 14:50:39 +01:00
Carl Fredrik Samson
a7ce98362a reworked chapter based on #25 2020-12-21 14:38:14 +01:00
Carl Fredrik Samson
67aa39b8f6 Merge pull request #23 from YenForYang/patch-1
Fix typo
2020-12-11 00:27:55 +01:00
YenForYang
3a1dca09fc Fix typo
A very minor typo under the Practical Rules for Pinning
2020-12-10 13:30:58 -06:00
Carl Fredrik Samson
94a194884a optin_builtin_traits is now called auto_traits 2020-12-06 01:49:29 +01:00
Carl Fredrik Samson
e4b84bdd83 Fixed error in green threads example. See: https://github.com/cfsamson/example-greenthreads/issues/20. Ugh... But it works now! 2020-12-06 01:34:53 +01:00
Carl Fredrik Samson
760fd57be3 Fixed naked function with arguments in green threads example. See https://github.com/cfsamson/example-greenthreads/issues/20 for more information. 2020-12-06 00:44:31 +01:00
Carl Fredrik Samson
3ba348601a prevent wake_by_ref from decreasing refcount. Fixes #22 2020-12-05 23:01:35 +01:00
Carl Fredrik Samson
8dfd7f445c updated links to fix #21 2020-12-05 22:11:41 +01:00
Carl Fredrik Samson
2128fc83d6 updated code comments re #20 2020-08-23 23:22:06 +02:00
Carl Fredrik Samson
734763b969 Merge pull request #20 from oblique/master
Fix `size` and `align` of raw vtable
2020-08-23 23:10:28 +02:00
oblique
527ec3835c waker context: Print size of Box<Box<SomeTrait>> 2020-08-09 22:10:13 +03:00
oblique
b0ca76b3d5 waker context: Fix size and align of raw vtable 2020-08-09 22:00:30 +03:00
Carl Fredrik Samson
4f275f1339 Merge pull request #18 from Yoric/patch-1
Typo fix
2020-05-31 11:02:22 +02:00
David Teller
3ce63ffd13 Typo fix 2020-05-31 10:51:18 +02:00
Carl Fredrik Samson
467578773f changed the green threads example to use llvm_asm due to https://github.com/rust-lang/rust/pull/69171 2020-05-20 23:09:11 +02:00
Carl Fredrik Samson
90f16be8e4 Merge pull request #17 from jamesrobb/jr_spelling_grammar
Small corrections to spelling, grammar, and a few phrases.
2020-05-19 14:44:57 +02:00
James Robb
6e75083b0e Phrase correction. The phrase sounded strange, so I took a stab at what I think the author meant. 2020-05-19 11:38:53 +00:00
James Robb
39169b737f Small conjugation correction. 2020-05-19 11:38:12 +00:00
James Robb
65401cbaf3 Small spelling and conjugation corrections. 2020-05-19 11:09:13 +00:00
James Robb
c7bb485b8a Small spelling and conjugation corrections. 2020-05-19 10:53:20 +00:00
James Robb
30b6e394c6 Small spelling corrections. 2020-05-19 10:37:38 +00:00
James Robb
6b41d2ff6d Mostly corrections to conjugation. 2020-05-19 10:28:27 +00:00
James Robb
ac5d80aa64 Oxford comma. 2020-05-19 10:11:53 +00:00
James Robb
18584400c7 Slightly awkward wording. 2020-05-19 10:08:21 +00:00
James Robb
92de09e917 Slightly awkward wording. 2020-05-19 10:06:23 +00:00
James Robb
aeb1c93449 Hyphen does not remove any ambiguity. 2020-05-19 10:03:47 +00:00
Carl Fredrik Samson
5fc2932899 Merge pull request #16 from WindSoilder/master
fix typo
2020-05-07 09:15:18 +02:00
WindSoilder
2d7d9f4680 fix typo 2020-05-07 09:04:16 +08:00
Carl Fredrik Samson
07aab4e76b Merge pull request #15 from WindSoilder/master
remove useless comment
2020-05-06 20:43:20 +02:00
WindSoilder
5da61651ba remove useless comment 2020-05-06 17:23:17 +08:00
Carl Fredrik Samson
0d669a8034 Merge pull request #14 from WindSoilder/master
make code compile, and fix typo
2020-05-06 08:58:14 +02:00
WindSoilder
41b28f466f make code compile, and fix typo 2020-05-06 09:11:03 +08:00
Carl Fredrik Samson
786faf4fd9 Removed the explicit call to close and mentioned a bug that can occur
when two tasks is given the same id.

The explicit close call is not needed. We can do that in the `Drop`
implementation instead. It's better to have accounting tasks like this
only one place and it didn't add anything to the example.

There is a subtle bug which occurs if two tasks are given the same Id.
I mentioned this explicitly since it's such an easy thing to do. I
added the fix as a reader excercise since for the examples sake I think
it's better to pass them in explicitly so that we don't "pollute" the
example with more code than strictly needed to get an understanding of
futures.
2020-04-27 00:02:41 +02:00
Carl Fredrik Samson
7db0aaa991 cleaned up and removed book directory for cleaner diffs 2020-04-18 02:31:57 +02:00
Carl Fredrik Samson
f4deaaf87b fix outdated links re: #13 2020-04-18 02:28:53 +02:00
Carl Fredrik Samson
a4c161c060 Merge pull request #12 from DarkEld3r/patch-1
Fix minor typo (som -> some)
2020-04-17 22:12:57 +02:00
Stanislav Tkach
66d706b9e5 Fix minor typo (som -> some) 2020-04-17 17:44:07 +03:00
Carl Fredrik Samson
8689ac98cc Merge pull request #11 from chengcyber/master
💄 panic button in mobile
2020-04-16 11:24:19 +02:00
Cheng
ad5bc20676 💄 panic button in mobile 2020-04-16 10:41:38 +08:00
Carl Fredrik Samson
a2f9535f3e fist sentence might be confusing, so I changed it 2020-04-14 23:56:59 +02:00
Carl Fredrik Samson
fbef19b079 more precise wording and fixed heap-pinning example which didn't work as expected 2020-04-14 23:51:54 +02:00
Carl Fredrik Samson
bd7e3c5572 added link to Chinese translation rec#issuecomment-613319223 + minor cleanup of code in Pin chapter 2020-04-14 23:05:54 +02:00
Carl Fredrik Samson
2fc79a9e03 added playground links to show problem using thread park/unpark 2020-04-14 00:37:03 +02:00
Carl Fredrik Samson
08b155698c Merge branch 'master' of https://github.com/cfsamson/books-futures-explained 2020-04-13 14:21:00 +02:00