From b15b9a5b329b24af6698264a1841ff105457c1df Mon Sep 17 00:00:00 2001 From: Hatter Jiang Date: Sun, 10 Dec 2023 00:15:15 +0800 Subject: [PATCH] feat: optimize code --- src/cmd_decrypt.rs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/cmd_decrypt.rs b/src/cmd_decrypt.rs index 979b712..212b74b 100644 --- a/src/cmd_decrypt.rs +++ b/src/cmd_decrypt.rs @@ -30,10 +30,10 @@ use crate::crypto_cryptor::{Cryptor, KeyNonce}; use crate::spec::{EncEncryptedMeta, TinyEncryptEnvelop, TinyEncryptEnvelopType, TinyEncryptMeta}; use crate::util::SecVec; use crate::util_digest::DigestWrite; -#[cfg(feature = "macos")] -use crate::util_keychainstatic; #[cfg(feature = "secure-enclave")] use crate::util_keychainkey; +#[cfg(feature = "macos")] +use crate::util_keychainstatic; use crate::util_progress::Progress; use crate::wrap_key::WrapKey; @@ -432,21 +432,21 @@ pub fn try_decrypt_key(config: &Option, pin: &Option, slot: &Option) -> XResult> { match envelop.r#type { - TinyEncryptEnvelopType::PgpRsa => try_decrypt_key_pgp(envelop, pin), + TinyEncryptEnvelopType::PgpRsa => try_decrypt_key_pgp_rsa(envelop, pin), TinyEncryptEnvelopType::PgpX25519 => try_decrypt_key_ecdh_pgp_x25519(envelop, pin), #[cfg(feature = "macos")] TinyEncryptEnvelopType::StaticX25519 => try_decrypt_key_ecdh_static_x25519(config, envelop), - TinyEncryptEnvelopType::PivP256 | TinyEncryptEnvelopType::PivP384 => try_decrypt_key_ecdh(config, envelop, pin, slot), + TinyEncryptEnvelopType::PivP256 | TinyEncryptEnvelopType::PivP384 => try_decrypt_piv_key_ecdh(config, envelop, pin, slot), #[cfg(feature = "secure-enclave")] TinyEncryptEnvelopType::KeyP256 => try_decrypt_se_key_ecdh(config, envelop), unknown_type => simple_error!("Unknown or unsupported type: {}", unknown_type.get_name()), } } -fn try_decrypt_key_ecdh(config: &Option, - envelop: &TinyEncryptEnvelop, - pin: &Option, - slot: &Option) -> XResult> { +fn try_decrypt_piv_key_ecdh(config: &Option, + envelop: &TinyEncryptEnvelop, + pin: &Option, + slot: &Option) -> XResult> { let wrap_key = WrapKey::parse(&envelop.encrypted_key)?; let (cryptor, algo_id) = match wrap_key.header.enc.as_str() { ENC_AES256_GCM_P256 => (Cryptor::Aes256Gcm, AlgorithmId::EccP256), @@ -571,7 +571,7 @@ fn try_decrypt_key_ecdh_static_x25519(config: &Option, envelo Ok(decrypted_key) } -fn try_decrypt_key_pgp(envelop: &TinyEncryptEnvelop, pin: &Option) -> XResult> { +fn try_decrypt_key_pgp_rsa(envelop: &TinyEncryptEnvelop, pin: &Option) -> XResult> { let mut pgp = util_pgp::get_openpgp()?; let mut trans = opt_result!(pgp.transaction(), "Connect OpenPGP card failed: {}");